Skip to content

Fix pointer to show correct updated location#606

Merged
martinRenou merged 1 commit intogeojupyter:mainfrom
arjxn-py:cursor-lat-long
Apr 7, 2025
Merged

Fix pointer to show correct updated location#606
martinRenou merged 1 commit intogeojupyter:mainfrom
arjxn-py:cursor-lat-long

Conversation

@arjxn-py
Copy link
Member

@arjxn-py arjxn-py commented Apr 6, 2025

Description

Shall fix #587

pointer.mp4

Checklist

  • PR has a descriptive title and content.
  • PR description contains references to any issues the PR resolves, e.g. Resolves #XXX.
  • PR has one of the labels: documentation, bug, enhancement, feature, maintenance
  • Checks are passing.
    Failing lint checks can be resolved with:
    • pre-commit run --all-files
    • jlpm run lint

📚 Documentation preview: https://jupytergis--606.org.readthedocs.build/en/606/
💡 JupyterLite preview: https://jupytergis--606.org.readthedocs.build/en/606/lite

@github-actions
Copy link
Contributor

github-actions bot commented Apr 6, 2025

Binder 👈 Launch a Binder on branch arjxn-py/jupytergis/cursor-lat-long

@arjxn-py arjxn-py added the bug Something isn't working label Apr 6, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Apr 6, 2025

Integration tests report: appsharing.space

Copy link
Member

@martinRenou martinRenou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!!

@martinRenou martinRenou merged commit 49eeda2 into geojupyter:main Apr 7, 2025
16 of 17 checks passed
@mfisher87
Copy link
Member

After thinking a bit longer about this, do we want the cursor location text to be pinned to the cursor itself? It can be hard to read until the collaborator stops moving. Perhaps it should be displayed on hovering the user's avatar in the top-right instead? 🤔

HaudinFlorence pushed a commit to HaudinFlorence/jupytergis that referenced this pull request Jan 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Collaborator cursor latitude longitude values are not updated

3 participants